Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 504cf430f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| WiFi.mode(WIFI_STA); | ||
| delay(100); | ||
| Serial.println(F("[boot] WiFi init... OK")); |
There was a problem hiding this comment.
The new boot status line always prints "[boot] WiFi init... OK" even if WiFi.mode(WIFI_STA) fails, which can mask real radio/init failures during factory bring-up and make later MAC/Wi-Fi test failures harder to diagnose. In this setup path, the success message should be conditioned on the WiFi.mode(...) return value (or equivalent error check) so the log reflects the true boot state.
Useful? React with 👍 / 👎.
nk25719
left a comment
nk25719
left a comment
There was a problem hiding this comment.
This line causes a compilation error.
// dfPlayer.enableACK(); // ← restore ACK for the rest of the session
| } | ||
|
|
||
| dfPlayer.setTimeOut(1000); | ||
| dfPlayer.enableACK(); // ← restore ACK for the rest of the session |
There was a problem hiding this comment.
/Users/naghamkheir/Repos/krake/Firmware/factoryTest/FactoryTest_wMenu/FactoryTest_wMenu.ino: In function 'bool initDFPlayer()':
/Users/naghamkheir/Repos/krake/Firmware/factoryTest/FactoryTest_wMenu/FactoryTest_wMenu.ino:737:21: error: 'void DFRobotDFPlayerMini::enableACK()' is private within this context
737 | dfPlayer.enableACK(); // ← restore ACK for the rest of the session
| ~~~~~~~~~~~~~~~~~~^~
In file included from /Users/naghamkheir/Repos/krake/Firmware/factoryTest/FactoryTest_wMenu/FactoryTest_wMenu.ino:98:
/Users/naghamkheir/Documents/Arduino/libraries/DFRobotDFPlayerMini/DFRobotDFPlayerMini.h:84:8: note: declared private here
84 | void enableACK();
| ^~~~~~~~~
There was a problem hiding this comment.
after commenting out:
// dfPlayer.enableACK(); // ← restore ACK for the rest of the session
The code introduced a compiling error, but when commenting out the dfp enabling code line, the code compiles and the Mac address is reported successfully after the [P] command.
There was a problem hiding this comment.
I think, this is because of outdated library version for DFRobotDFPlayerMini, the latest version (1.0.6) allows this code of line to compile properly, updating the library should resolve this error.
2 participants
Links
What & Why
WiFi.macAddress()was returning00:00:00:00:00:00in the splash because the WiFi driver wasn't initialized yetWiFi.mode(WIFI_STA)+delay(100)insetup()before the splash prints, then immediately set back toWIFI_OFF[boot]status lines for LittleFS and WiFi init so operator knows board is alive during startupsplashserial()for device traceabilityValidation / How to Verify
[boot] LittleFS... OKand[boot] WiFi init... OKappear on startupMAC (STA):in the splash shows a real MAC address (not00:00:00:00:00:00)Artifacts (attach if relevant)
Checklist